RED-75: instead of join v1 use new standby number (from cycleChain)
#26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RED-75 GUI: Display Joining and Syncing nodes in GUI Network Size
Our Current GUI displays the following: Network Tab Network Size
The team working on the new gui would like to use this data as well but some information is currently not being displayed. Task: Current GUI should show the number of nodes in Standby Current GUI should show the number of nodes in Joining (Any substate for nodes that are joining EX: Selected, ready to sync, syncing, etc... should display as "Syncing") |
ahmxdiqbal
reviewed
Apr 24, 2024
ahmxdiqbal
approved these changes
Apr 26, 2024
urnotsam
pushed a commit
that referenced
this pull request
Jun 3, 2024
…#26) * fix: instead of join v1 use new `standby` number (from cycleChain) * refactor: use standby count from join v2 map and use desired from AutoScaler * fix: use the getter instead of direct field access for standbyNodes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.